Add option allow_redundancy to rule explicit_type_interface #2313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## master #2313 +/- ##
=========================================
+ Coverage 91.99% 92% +<.01%
=========================================
Files 296 296
Lines 14886 14929 +43
=========================================
+ Hits 13694 13735 +41
- Misses 1192 1194 +2
Continue to review full report at Codecov.
|
Jeehut
changed the title
|
I marked this PR [WIP] for now, as I need to update this to use a custom option following the discussions in #2312. |
Jeehut
force-pushed
the
explicit-type-interface
branch
from
289fe84
to
7643c8b
Compare
Jeehut
changed the title
|
Just added an option like discussed in #2312 – this is now ready to merge from my point of view. Looking forward to for reviews! |
marcelofabri
approved these changes
Jul 26, 2018
CHANGELOG.md
Outdated
| @@ -67,6 +67,11 @@ | |||
| [Marcelo Fabri](https://github.com/marcelofabri) | |||
| [#2233](https://github.com/realm/SwiftLint/issues/2233) | |||
|
|
|||
| * Make rule `explicit_type_interface` compatible with rule | |||
There was a problem hiding this comment.
can you move this to the "Enhancements" section and mention the configuration option?
Jeehut
force-pushed
the
explicit-type-interface
branch
from
7643c8b
to
b4f960b
Compare
|
I just rebased and moved the changelog entry accordingly. |
| @@ -35,6 +35,11 @@ | |||
| * Add `private_only` configuration to `prefixed_toplevel_constant` rule | |||
| [Keith Smiley](https://github.com/keith) | |||
| [#2315](https://github.com/realm/SwiftLint/pull/2315) | |||
|
|
|||
| * Make rule `explicit_type_interface` compatible with rule | |||
There was a problem hiding this comment.
can you please mention that this is possible with the allow_redundancy configuration key?
marcelofabri
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2312.