Use official Hytale mavel repository and fix Github Actions workflow #19
+153
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… HytaleServer.jar from official maven repository. Added permissions in workflows to allow github action to create new releases.
Removed unused database driver dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
gradle.properties still had a placeholder (# ...) above hytale_build, offering no guidance on what value to set.
Contributors were picking arbitrary versions, leading to mismatched server jars and build failures.
Solution
Replace the placeholder with a clear comment that explains the purpose of hytale_build, points to the launcher as the source of truth, and documents the expected YYYY.MM.DD- format so it matches the selected patchline.
This PR solves #17