Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pylint fix for readthedocs.core #5650

Merged
merged 1 commit into from
May 9, 2019
Merged

pylint fix for readthedocs.core #5650

merged 1 commit into from
May 9, 2019

Conversation

saadmk11
Copy link
Member

@saadmk11 saadmk11 commented May 1, 2019 •
edited
Loading

If this way works then I'll continue with the other apps.

ref: #5517

stsewd
stsewd approved these changes May 1, 2019
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how others feel about this, but I think having a constant as the template makes logging confusing, if we don't pass a required argument (in **log_kwargs) it will blow up. If we are ok, we can just merge this 👍

This was referenced May 3, 2019
Merged
Merged
Merged
Merged
@stsewd
Copy link
Member

stsewd commented May 9, 2019

Merging, we can improve this later (current implementation has the same problem anyway)

@stsewd stsewd merged commit 2308f38 into readthedocs:master May 9, 2019
@saadmk11 saadmk11 deleted the fix-lint-core-app branch May 9, 2019 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saadmk11 @stsewd