-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update common to its latest version #5517
Conversation
Looks like there are some py2 bits that can be removed https://github.com/rtfd/readthedocs.org/blob/50cb9a24045cf29c5719ffb92fd22cfdd54b0f34/readthedocs/config/models.py#L8 |
We can remove the object inheritance (there are just a couple of places). But we also have |
@stsewd I think making our code to pass the linter completely could be a "Good First Issue". Marking it as that to allow folk find it and helps us on this. The actionable here is:
|
If anyone wants to send a PR for this, I'd appreciate separating it in little chunks, so it's easy to review :) |
@stsewd I have found 50+ |
I think for each constant or module. |
Created All the PRs needed to fix the lint issues. :) |
42c4591
to
1f304a2
Compare
1f304a2
to
75b4ef1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linter is fixed!
Thanks @saadmk11!
Glad I could Help ! 💯 |
Get new configs from common.