This repository has been archived by the owner on Jul 29, 2022. It is now read-only.
Use the new Search Service #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickael-menu
force-pushed
the
feature/search
branch
from
9507753 to
4faf0ec
Compare
mickael-menu
force-pushed
the
feature/search
branch
from
4faf0ec to
e43a1ad
Compare
|
shall we merge this PR please? |
|
I still have a few changes to do on this one, from the experience implementing it on iOS. I'll also present the associated proposal to the dev call today, and see if there are other stuff to adjust. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See readium/r2-shared-kotlin#154