Skip to content
This repository has been archived by the owner on Jul 29, 2022. It is now read-only.

Add a Publication Search Service for background search #154

Merged
merged 21 commits into from
May 27, 2021

Conversation

mickael-menu
Copy link
Member

@mickael-menu mickael-menu commented May 3, 2021

Added

  • A new Publication SearchService to search through the resources' content, with a default implementation StringSearchService.

@mickael-menu mickael-menu marked this pull request as ready for review May 7, 2021 13:31
@mrifni
Copy link

mrifni commented May 19, 2021

I am eagerly waiting on this change, whats like the time frame to get this PR merged and what part of the release this will go into ?

@mickael-menu
Copy link
Member Author

mickael-menu commented May 19, 2021

@mrifni For a release we'll have to wait a few more weeks, there's also the new audiobook navigator to merge in before. But we could merge this in develop pretty quickly. Would you be able to test from develop?

We're integrating these changes at my company this week, so I'll make sure everything works well before merging in develop.

@mickael-menu
Copy link
Member Author

Btw not to get your hopes up too high, the current implementation finds search results and opens the publication at the right position. But the search results are not highlighted in the navigator. This will need a separate "decorator" feature which will come later. This is my next subject.

@mrifni
Copy link

mrifni commented May 19, 2021

sure, I can test it. Highlight fix is my next big expectations :)

@mrifni
Copy link

mrifni commented May 25, 2021

any idea when this would be merged and be part of a release?

@mickael-menu mickael-menu merged commit cf31184 into develop May 27, 2021
@mickael-menu mickael-menu deleted the feature/search branch May 27, 2021 08:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants