-
Notifications
You must be signed in to change notification settings - Fork 32
Add a Publication Search Service for background search #154
Conversation
1be79a7
to
3820c2b
Compare
...hared/src/main/java/org/readium/r2/shared/publication/services/search/StringSearchService.kt
Outdated
Show resolved
Hide resolved
...hared/src/main/java/org/readium/r2/shared/publication/services/search/StringSearchService.kt
Outdated
Show resolved
Hide resolved
I am eagerly waiting on this change, whats like the time frame to get this PR merged and what part of the release this will go into ? |
@mrifni For a release we'll have to wait a few more weeks, there's also the new audiobook navigator to merge in before. But we could merge this in We're integrating these changes at my company this week, so I'll make sure everything works well before merging in |
Btw not to get your hopes up too high, the current implementation finds search results and opens the publication at the right position. But the search results are not highlighted in the navigator. This will need a separate "decorator" feature which will come later. This is my next subject. |
sure, I can test it. Highlight fix is my next big expectations :) |
any idea when this would be merged and be part of a release? |
Added
SearchService
to search through the resources' content, with a default implementationStringSearchService
.