add note about eslint:no-label #1009
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for reactjs ready! Built with commit 1135d67 |
alexkrolick
reviewed
Jun 27, 2018
| @@ -76,6 +76,18 @@ handleSomething() { | |||
| } | |||
| ``` | |||
|
|
|||
| One common pitfall when writing arrow functions is accidentally relying on labels and implicit returns: | |||
There was a problem hiding this comment.
I would call this out as a 'rarely-used language feature called "labels"'
There was a problem hiding this comment.
I don't have strong feelings on this, whoever is merging or reviewing please feel free to change it or decide.
|
Hey @swyxio, good to see you! Sorry we never reviewed this. Going to close since it's against the old docs site, but if you think this is still needed I think there are a few good places to mention this in the new docs. Will comment on the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1004