Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend eslint:no-label for functional setState #1004

Open
tsiq-swyx opened this issue Jun 26, 2018 · 2 comments · May be fixed by #1009
Open

Recommend eslint:no-label for functional setState #1004

tsiq-swyx opened this issue Jun 26, 2018 · 2 comments · May be fixed by #1009

Comments

@tsiq-swyx
Copy link

this is a pretty common mistake when using the functional form of setState:

image

and we have no warning in React (yet) for this when it happens. easiest guard is having eslint:no-label tell you about it. Should we add a mention in the setState docs?
@alexkrolick
Copy link
Collaborator

Maybe add a note here? https://reactjs.org/docs/faq-state.html#what-is-the-difference-between-passing-an-object-or-a-function-in-setstate

@tsiq-swyx
Copy link
Author

yeah. i'm also trying to add a warning in react itself: facebook/react#13111

swyxio added a commit to swyxio/reactjs.org that referenced this issue Jun 27, 2018
@swyxio
add note about eslint:no-label
1135d67 
closes reactjs#1004
@swyxio swyxio linked a pull request Jun 27, 2018 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add note about eslint:no-label swyxio/reactjs.org
2 participants
@alexkrolick @tsiq-swyx