Remove lodash from browserify - #80
Closed
ndreckshage wants to merge 1 commit into
Closed
Conversation
Contributor
|
@ndreckshage Thanks for opening this up for discussion. I'm thinking we can definitely work out a change that might reduce the size of the bundle. I'm hoping that perhaps we might be able to move completely off browserify and onto webpack completely with some of its handling of bundles. I think that if we just required the lodash.assign function, we could likely get rid of most of the lodash bulk. |
Contributor
|
@ndreckshage Would you mind looking at #144 and letting me know your thoughts? |
Collaborator
|
Just pinging. |
Contributor
|
I'm going to close this based on the changes that were made to enhance the build process and reduce the minified build size in #159 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge! Untested etc. Just for discussion.
Setting lodash.assign as a global in browserify config reduces the unminified build in dist from 49.5k to 16.1k. And the minified version from 20.6k to 11.3k. Non gzipped (...Github should show gzip size).
I almost didn't use the library + wrote my own because the numbers looked crazy 😄. Maybe just add size to readme? This is tiny gzipped, minified, and without lodash (4k). Thanks!