Move to using webpack for building the library - #144
Merged
Conversation
This allows us to remove the dependency on browserify completely.
claydiffrient
force-pushed
the
development-improvements
branch
from
March 27, 2016 05:30
bc283a4 to
72c8498
Compare
Contributor
|
Marking |
Collaborator
|
@claydiffrient, this PR is great + @doque's PR. |
Contributor
Author
|
@diasbruno Looks like there's some conflicts, and I don't have the time right now to resolve them. I'll take a look tonight :) |
Collaborator
|
No problem. Just trying to keep this updated. |
Collaborator
|
...and thanks to take the time to respond. |
Contributor
Author
|
@doque @diasbruno now released as v1.1.1 |
Collaborator
|
awesome, @claydiffrient! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to remove the dependency on browserify
completely.
The problem is that the size of the compiled library is 719 kB unminified and 190 kB minified. The current implementation via browserify produces 49 kB unminified and 21 kB minified. That's quite the difference.
Any ideas on how to get that down?