v2: Assign all nextProps dataset properties to chart

[ianks]

This resolves my issue posted in #84

Essentially, only the data was being updated from the datasets. This PR makes its so all of the properties from the dataset are now assigned to the new chart. This will allow for things like:

1. Updating a label
2. Updating a fill color
3. etc.

It also re-introduces the redraw prop to force a re-render of the canvas.

I have only tested this with the Line chart, so if anyone has any production apps where there make use of Doughnut charts, etc. please give this branch a whirl!

[ianks]

Anyone give this branch a whirl yet?

[nrempel]

I've installed this branch to test out v2 functionality. So far everything works great for me.

Thanks for putting in that effort!

[stevewillard]

It's working great for me, too!

[dmhood]

Works for me as well

[gor181]

Tested with Doughnuts and Pie charts. Works great!

[dougmolineux]

Would it be better to use setState here? Thank you for this commit!

[gor181]

@dougmolineux I would agree.
Even moving this.initializeChart from componentDidMount to componentWillMount to avoid unecessary re-render.

[ianks]

I don't think this is possible since initializeChart relies on the chart being mounted.

[ianks]

It also might not be possible to use setState since it is asynchronous, and the chart being available is required to be sync the way the code is currently written. I'd rather not turn this PR into a full re-factor.

[gor181]

@ianks can you make the changes mentioned in comments if you find them suitable? How can I assist?

[ianks]

I'll make the changes when I get home tomorrow.

[russelldc]

Does the new combining feature in v2 work with these changes?

[ianks]

@russelldc I am not sure. I have not tested it. Can you give it a try?

[eluciano11]

Hi @russelldc, I'm using combined charts with this branch and it works properly.

Example:

[fscz]

It still does not work for me. Fix: in core.js

replace

var chartDataset = chart.data.datasets[setIndex];

      for (var property in set) {
        if (set.hasOwnProperty(property)) {
          chartDataset[property] = set[property];
        }
      }

with

var chartDataset = {};

      for (var property in set) {
        if (set.hasOwnProperty(property)) {
          chartDataset[property] = set[property];
        }
      }
      chart.data.datasets[setIndex] = chartDataset;

[RezaRahmati]

I get this error using chartjs:2.1.6

core.js:60 Uncaught TypeError: (intermediate value)[chartType] is not a function
classData.initializeChart @ core.js:60

[nesbtesh]

How do I install chart.js-v2 with npm to help with the testing ?

[ianks]

@nesbtesh add this to your package.json

   "react-chartjs": "git+https://github.com/jhudson8/react-chartjs.git#chartjs-v2",