Skip to content
This repository was archived by the owner on Jul 19, 2019. It is now read-only.

Copy across the specified properties of each dataset when updating the chart #98

Closed

Conversation

tomduncalf
Copy link

I noticed that no properties of the datasets are copied across when updating the chart from a props change - in my case, trying to show or hide a series with a checkbox.

I'm open for discussion on the best way to do this - for now I've just created a whilelist of properties to copy across (with just my use case in it :)) but maybe there is a better way... could the entire datasets property just be copied across? I wasn't sure what the reasoning behind iterating over it and copying across one by one is.

@tomduncalf tomduncalf changed the title Copy across the specified properties of each dataset when updating th… Copy across the specified properties of each dataset when updating the chart Apr 8, 2016
@tomduncalf
Copy link
Author

@austinpray any thoughts on this?

@tomduncalf
Copy link
Author

Just seen #109 which looks like a better implementation of this, closing

@tomduncalf tomduncalf closed this May 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant