move error tests to their own URL

reactive-python · Archmonger · Sep 25, 2023 · Sep 19, 2023 · Sep 19, 2023 · Sep 21, 2023
commit 8ac34157cf3d60abaa125c58a5b415945c870bfb
@@ -71,6 +71,10 @@ <h1>ReactPy Test Page</h1>
   <hr>
   {% component "test_app.components.view_to_component_kwargs" %}
   <hr>
+  {% component "test_app.components.view_to_component_decorator" %}
+  <hr>
+  {% component "test_app.components.view_to_component_decorator_args" %}
+  <hr>
   {% component "test_app.components.view_to_component_sync_func_compatibility" %}
   <hr>
   {% component "test_app.components.view_to_component_async_func_compatibility" %}
@@ -83,20 +87,6 @@ <h1>ReactPy Test Page</h1>
   <hr>
   {% component "test_app.components.view_to_iframe_args" %}
   <hr>
-  {% component "test_app.components.view_to_component_decorator" %}
-  <hr>
-  {% component "test_app.components.view_to_component_decorator_args" %}
-  <hr>
-  <div id="component_does_not_exist_error">{% component "test_app.components.does_not_exist" %}</div>
-  <hr>
-  <div id="component_param_error">{% component "test_app.components.hello_world" invalid_param="random_value" %}</div>
-  <hr>
-  <div id="invalid_host_error">{% component "test_app.components.hello_world" host="https://example.com/" %}</div>
-  <hr>
-  <div id="broken_postprocessor_query">
-    {% component "test_app.components.broken_postprocessor_query" %}
-  </div>
-  <hr>
 </body>
 
 </html>
@@ -0,0 +1,28 @@
+{% load static %} {% load reactpy %}
+<!DOCTYPE html>
+<html lang="en">
+
+<head>
+    <meta charset="UTF-8" />
+    <meta http-equiv="X-UA-Compatible" content="IE=edge" />
+    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+    <link rel="shortcut icon" type="image/png" href="{% static 'favicon.ico' %}" />
+    <title>ReactPy</title>
+</head>
+
+<body>
+    <h1>ReactPy Errors Test Page</h1>
+    <hr>
+    <div id="component_does_not_exist_error">{% component "test_app.components.does_not_exist" %}</div>
+    <hr>
+    <div id="component_param_error">{% component "test_app.components.hello_world" invalid_param="random_value" %}</div>
+    <hr>
+    <div id="invalid_host_error">{% component "test_app.components.hello_world" host="https://example.com/" %}</div>
+    <hr>
+    <div id="broken_postprocessor_query">
+        {% component "test_app.components.broken_postprocessor_query" %}
+    </div>
+    <hr>
+</body>
+
+</html>
@@ -277,16 +277,6 @@ def test_view_to_component_decorator_args(self):
             "#view_to_component_decorator_args[data-success=true]"
         ).wait_for()
 
-    def test_component_does_not_exist_error(self):
-        broken_component = self.page.locator("#component_does_not_exist_error")
-        broken_component.wait_for()
-        self.assertIn("ComponentDoesNotExistError:", broken_component.text_content())
-
-    def test_component_param_error(self):
-        broken_component = self.page.locator("#component_param_error")
-        broken_component.wait_for()
-        self.assertIn("ComponentParamError:", broken_component.text_content())
-
     def test_component_session_exists(self):
         """Session should exist for components with args/kwargs."""
         component = self.page.locator("#parametrized-component")
@@ -314,8 +304,8 @@ def test_component_session_missing(self):
     def test_custom_host(self):
         """Make sure that the component is rendered by a separate server."""
         new_page = self.browser.new_page()
+        new_page.goto(f"{self.live_server_url}/port/{self._port2}/")
         try:
-            new_page.goto(f"{self.live_server_url}/port/{self._port2}/")
             elem = new_page.locator(".custom_host-0")
             elem.wait_for()
             self.assertIn(
@@ -341,10 +331,8 @@ def test_custom_host_wrong_port(self):
     def test_host_roundrobin(self):
         """Verify if round-robin host selection is working."""
         new_page = self.browser.new_page()
+        new_page.goto(f"{self.live_server_url}/roundrobin/{self._port}/{self._port2}/8")
         try:
-            new_page.goto(
-                f"{self.live_server_url}/roundrobin/{self._port}/{self._port2}/8"
-            )
             elem0 = new_page.locator(".custom_host-0")
             elem1 = new_page.locator(".custom_host-1")
             elem2 = new_page.locator(".custom_host-2")
@@ -372,21 +360,11 @@ def test_host_roundrobin(self):
         finally:
             new_page.close()
 
-    def test_invalid_host_error(self):
-        broken_component = self.page.locator("#invalid_host_error")
-        broken_component.wait_for()
-        self.assertIn("InvalidHostError:", broken_component.text_content())
-
-    def test_broken_postprocessor_query(self):
-        broken_component = self.page.locator("#broken_postprocessor_query pre")
-        broken_component.wait_for()
-        self.assertIn("SynchronousOnlyOperation:", broken_component.text_content())
-
     def test_prerender(self):
         """Verify if round-robin host selection is working."""
         new_page = self.browser.new_page()
+        new_page.goto(f"{self.live_server_url}/prerender/")
         try:
-            new_page.goto(f"{self.live_server_url}/prerender/")
             string = new_page.locator("#prerender_string")
             vdom = new_page.locator("#prerender_vdom")
             component = new_page.locator("#prerender_component")
@@ -414,3 +392,31 @@ def test_prerender(self):
             )
         finally:
             new_page.close()
+
+    def test_component_errors(self):
+        new_page = self.browser.new_page()
+        new_page.goto(f"{self.live_server_url}/errors/")
+        try:
+            # ComponentDoesNotExistError
+            broken_component = new_page.locator("#component_does_not_exist_error")
+            broken_component.wait_for()
+            self.assertIn(
+                "ComponentDoesNotExistError:", broken_component.text_content()
+            )
+
+            # ComponentParamError
+            broken_component = new_page.locator("#component_param_error")
+            broken_component.wait_for()
+            self.assertIn("ComponentParamError:", broken_component.text_content())
+
+            # InvalidHostError
+            broken_component = new_page.locator("#invalid_host_error")
+            broken_component.wait_for()
+            self.assertIn("InvalidHostError:", broken_component.text_content())
+
+            # SynchronousOnlyOperation
+            broken_component = new_page.locator("#broken_postprocessor_query pre")
+            broken_component.wait_for()
+            self.assertIn("SynchronousOnlyOperation:", broken_component.text_content())
+        finally:
+            new_page.close()
@@ -33,6 +33,7 @@ class AccessUser:
         "roundrobin/<int:port1>/<int:port2>/<int:count>/",
         views.host_port_roundrobin_template,
     ),
+    path("errors/", views.errors_template),
     path("", include("test_app.prerender.urls")),
     path("", include("test_app.performance.urls")),
     path("reactpy/", include("reactpy_django.http.urls")),

@@ -13,6 +13,10 @@ def base_template(request):
     return render(request, "base.html", {"my_object": TestObject(1)})
 
 
+def errors_template(request):
+    return render(request, "errors.html", {})
+
+
 def host_port_template(request: HttpRequest, port: int):
     host = request.get_host().replace(str(request.get_port()), str(port))
     return render(request, "host_port.html", {"new_host": host})