ViewNotRegisteredError and ViewDoesNotExistError

src/reactpy_django/components.py

@@ -14,7 +14,7 @@
 from reactpy import component, hooks, html, utils
 from reactpy.types import Key, VdomDict
 
-from reactpy_django.exceptions import ComponentNotRegisteredError
+from reactpy_django.exceptions import ViewNotRegisteredError
 from reactpy_django.utils import generate_obj_name, import_module, render_view
 
 
@@ -220,15 +220,12 @@ def _view_to_iframe(
     """The actual component. Used to prevent pollution of acceptable kwargs keys."""
     from reactpy_django.config import REACTPY_REGISTERED_IFRAME_VIEWS
 
-    if isinstance(view, str):
-        dotted_path = view
-    else:
-        dotted_path = generate_obj_name(view).replace("<", "").replace(">", "")
+    dotted_path = view if isinstance(view, str) else generate_obj_name(view)
     registered_view = REACTPY_REGISTERED_IFRAME_VIEWS.get(dotted_path)
 
     if not registered_view:
-        raise ComponentNotRegisteredError(
-            f"'{dotted_path}' has not been registered as an iframe component! "
+        raise ViewNotRegisteredError(
+            f"'{dotted_path}' has not been registered as an iframe! "
             "Are you sure you called `register_iframe` within a Django `AppConfig.ready` method?"
         )
 

src/reactpy_django/exceptions.py

@@ -14,5 +14,9 @@ class ComponentCarrierError(ValueError):
     ...
 
 
-class ComponentNotRegisteredError(ComponentDoesNotExistError):
+class ViewNotRegisteredError(AttributeError):
+    ...
+
+
+class ViewDoesNotExistError(AttributeError):
     ...

src/reactpy_django/utils.py

@@ -24,7 +24,11 @@
 from reactpy.core.layout import Layout
 from reactpy.types import ComponentConstructor
 
-from reactpy_django.exceptions import ComponentDoesNotExistError, ComponentParamError
+from reactpy_django.exceptions import (
+    ComponentDoesNotExistError,
+    ComponentParamError,
+    ViewDoesNotExistError,
+)
 
 _logger = logging.getLogger(__name__)
 _component_tag = r"(?P<tag>component)"
@@ -85,39 +89,45 @@ async def render_view(
     return response
 
 
-def register_component(dotted_path: str) -> ComponentConstructor:
-    """Adds a component to the list of known registered components."""
+def register_component(component: ComponentConstructor | str):
+    """Adds a component to the list of known registered components.
+
+    Args:
+        component: The component to register. Can be a component function or dotted path to a component.
+
+    """
     from reactpy_django.config import (
         REACTPY_FAILED_COMPONENTS,
         REACTPY_REGISTERED_COMPONENTS,
     )
 
-    if dotted_path in REACTPY_REGISTERED_COMPONENTS:
-        return REACTPY_REGISTERED_COMPONENTS[dotted_path]
-
+    dotted_path = (
+        component if isinstance(component, str) else generate_obj_name(component)
+    )
     try:
         REACTPY_REGISTERED_COMPONENTS[dotted_path] = import_dotted_path(dotted_path)
     except AttributeError as e:
         REACTPY_FAILED_COMPONENTS.add(dotted_path)
         raise ComponentDoesNotExistError(
             f"Error while fetching '{dotted_path}'. {(str(e).capitalize())}."
         ) from e
-    return REACTPY_REGISTERED_COMPONENTS[dotted_path]
 
 
 def register_iframe(view: Callable | View | str):
-    """Registers a view to be used as an iframe component."""
-    from reactpy_django.config import REACTPY_REGISTERED_IFRAME_VIEWS
+    """Registers a view to be used as an iframe component.
 
-    resolved_view: Callable | View
-    if isinstance(view, str):
-        resolved_view = import_dotted_path(view)
-        dotted_path = view
-    else:
-        resolved_view = view
-        dotted_path = generate_obj_name(view).replace("<", "").replace(">", "")
+    Args:
+        view: The view to register. Can be a function or class based view, or a dotted path to a view.
+    """
+    from reactpy_django.config import REACTPY_REGISTERED_IFRAME_VIEWS
 
-    REACTPY_REGISTERED_IFRAME_VIEWS[dotted_path] = resolved_view
+    dotted_path = view if isinstance(view, str) else generate_obj_name(view)
+    try:
+        REACTPY_REGISTERED_IFRAME_VIEWS[dotted_path] = import_dotted_path(dotted_path)
+    except AttributeError as e:
+        raise ViewDoesNotExistError(
+            f"Error while fetching '{dotted_path}'. {(str(e).capitalize())}."
+        ) from e
 
 
 def import_dotted_path(dotted_path: str) -> Callable:

tests/test_app/tests/test_components.py

@@ -419,11 +419,9 @@ def test_component_errors(self):
             broken_component.wait_for()
             self.assertIn("SynchronousOnlyOperation:", broken_component.text_content())
 
-            # ComponentNotRegisteredError
+            # ViewNotRegisteredError
             broken_component = new_page.locator("#view_to_iframe_not_registered pre")
             broken_component.wait_for()
-            self.assertIn(
-                "ComponentNotRegisteredError:", broken_component.text_content()
-            )
+            self.assertIn("ViewNotRegisteredError:", broken_component.text_content())
         finally:
             new_page.close()