Warn if a part/quit is received and no channelUsers is set #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempts to fix reactiflux#216's crash but is unlikely to fix the underlying issue (that somehow the client isn't saving a list of nicks in a channel, either because the server isn't sending a names event, or the node-irc library is processing it poorly, or otherwise).
Throne3d
force-pushed
the
fix/warn-on-no-names
branch
from
0307753 to
0359657
Compare
1 similar comment
|
Rebased onto master, fixed a merge conflict. |
ekmartin
approved these changes
Apr 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #216's crash but is unlikely to fix the underlying issue (that somehow the client isn't saving
a list of nicks in a channel, either because the server isn't sending a names event, or the node-irc library is processing it poorly, or otherwise).
I'm not sure this should be merged until a proper fix is found, but this shouldn't damage anything anyway.
I couldn't produce the actual crash on the particular server so it might be related to the particular channel in use, but this should hopefully work as a stopgap measure so the bot can be used with status messages (well, joins and probably parts) on such channels, while still alerting when weird behavior is going on.