Bot crashes when user leaves on IRC

[Abchrisabc]

So after my stupidness in installing the distro's default for node.js (4.2.3) instead of atleast 6, I have found some other issue.

Whenever a user parts the IRC channel, the bot throws an error and crashes with
Cannot read property 'delete' of undefined.

Below is the Text I can see in Console.
https://gist.github.com/Abchrisabc/3ba0f7ee2778127252b215932d3ec0a5

[ekmartin]

Are you saying you're using Node.js 4.2.3 or 6?

Regardless, @Throne3d: maybe there's a possibility for a race condition if the names results lands after the first quit/part? So that this.channelUsers[channel] accesses should be replaced by this.channelUsers[channel] && this.channelUsers[channel].somethingHere etc.?

[Abchrisabc]

I do use 6 after uninstalling 4.2.3 and manually installing 6. So this issue is happening on 6.

[Throne3d]

The docs implied that the names event would be received at the same time (or very near to) when the bot joins a channel. It's possible there's a race condition, yeah, and that might be a useful guard to have anyway, but if the names event just isn't sent for some reason (eg because they're unicode names and the irc library fails to parse them? I'm not sure if that's the case but it might be) then it's going to be hard to deal with.

@Abchrisabc Do you have ircStatusNotices enabled or disabled? I'm assuming enabled but I don't think you specified, and if disabled then this is a different problem from what we think.

[Abchrisabc]

@Throne3d Yes I do have ircStatusNotices enabled.

[Throne3d]

Can you tell me what IRC server this occurs on? (Possibly they use some IRC server software that doesn't send a names event?)

(Also I assume ircStatsNotices is just a typo here, since the actual config is ircStatusNotices)

[Abchrisabc]

@Throne3d

irc.esper.net

and yes that was a typo xD

And I do want to add the fact that upon joining it doesn't crash.

[Throne3d]

I don't seem to be able to reproduce it particularly easily – just joining the channel and parting / quitting doesn't produce the same problem for me.

Can you add "debug": true to ircOptions in the config and do another paste? (Make sure to remove any passwords or other sensitive information if any appears there. It might not provide all the info I want but it may help narrow it down, such as showing which specific events the bot received…)

If that fails, it might be a problem specific to the channel you're using this bot in.

[Abchrisabc]

@Throne3d Here is the debug.

Testing this a bit further it only happens on QUIT or TIMEOUT not on PART.

[Throne3d]

I think I've fixed this in #219. If you know how, you could check out that branch, build the code, and test that out?

[Abchrisabc]

Just cloned the repo and indeed the problem is fixed in #219. Thanks 👍