Create InputGroup component (#430)
#443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedrich-schindler
requested changes
Jan 16, 2023
adamkudrna
reviewed
Feb 20, 2023
Member
|
Please do a rebase against the latest |
dacerondrej
force-pushed
the
feature/430
branch
from
b6098b1 to
3d19d62
Compare
adamkudrna
requested changes
Mar 1, 2023
Member
adamkudrna
left a comment
adamkudrna
left a comment
There was a problem hiding this comment.
When I was implementing the support of custom inner border radius, I found a few more details that need to be changed. Will you please have a look at it? 🙏🏻
Member
|
Theming of inner border radius: #454. |
dacerondrej
force-pushed
the
feature/430
branch
from
c9d1b1c to
990bf65
Compare
adamkudrna
requested changes
Apr 26, 2023
Member
adamkudrna
left a comment
adamkudrna
left a comment
There was a problem hiding this comment.
Cool! 👍🏻 Last two major things before ✅:
- The context of horizontal form layout needs to be fixed.
- I'd push harder in documenting all the exceptions of when component's props are overridden or suppresed by parent InputGroup.
adamkudrna
approved these changes
Apr 29, 2023
adamkudrna
force-pushed
the
feature/430
branch
2 times, most recently
from
7be906e to
b5fc344
Compare
mbohal
reviewed
May 2, 2023
bedrich-schindler
approved these changes
May 2, 2023
adamkudrna
approved these changes
May 3, 2023
Member
adamkudrna
left a comment
adamkudrna
left a comment
There was a problem hiding this comment.
Now I believe it's all done 🙂.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any suggestions, especially regarding CSS and documentation, are warmly welcome. @adamkudrna
Build failed due to asset size limit. I will not change the limit for now as it is solved in simultaneous pull requests which will be probably merged before this one.
Closes #430