Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create inputgroup component #430

Closed
mbohal opened this issue Nov 1, 2022 · 0 comments · Fixed by #443
Closed

create inputgroup component #430

mbohal opened this issue Nov 1, 2022 · 0 comments · Fixed by #443
Assignees
Labels

Comments

@mbohal
Copy link
Contributor

mbohal commented Nov 1, 2022

We need a new layout component InputGroup.

It will accept as props:

  • children: an array of elements
    • one of (defined in docs only, we can not validate their type):
      • Button
      • SelectField
      • TextField
    • their label must be hidden, but present for accessibility reasons
    • some of thier props will be overloaded
      • size according to the size prop of the InputGroup element
      • for Button the prop priority will either be set to filled as there is no one to pay for the other options or it must work out of the box with no extra work
      • for SelectField and TextField the prop variant will either be set to outline as there is no one to pay for the other options or it must work out of the box with no extra work
  • validationTexts: An array of validation messages. These are not semantically tied to the children elements, the connection should be expressed in textual form in the actual message. The individual children elements must not show any validationText, they only show their respective validationState.
  • size: Defines the size of the children elements. If the element specifies a size it will be overloaded by the InputGroup prop value.
  • layout: Indicates if it is horizontal or vertical

Design:

Inputgroup.pdf

@mbohal mbohal added the feature label Nov 1, 2022
@mbohal mbohal assigned dacerondrej and unassigned hubacekj Jan 2, 2023
dacerondrej added a commit that referenced this issue Jan 10, 2023
dacerondrej added a commit that referenced this issue Feb 27, 2023
dacerondrej added a commit that referenced this issue Mar 3, 2023
dacerondrej added a commit that referenced this issue Mar 27, 2023
adamkudrna pushed a commit that referenced this issue Apr 29, 2023
adamkudrna pushed a commit that referenced this issue Apr 29, 2023
adamkudrna pushed a commit that referenced this issue May 3, 2023
adamkudrna pushed a commit that referenced this issue May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants