Skip to content

Commit

Permalink
Use modern Android libc++ in Yoga and React Native OSS (#39795)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebook/react-native#39795
X-link: facebook/yoga#1412

Android NDK 25 uses a version of libc++ that is more than three years old, missing a lot of basic features of C++ 20. This is rectified in NDK 26 (latest LTS NDK), which brings us up to date with latest Clang (17, released this year), and adds a new policy where future NDK versions will bump libc++ as part of bumping LLVM/Clang.

This requires an a beta AGP version (and corresponding Android Studio Preview). Based on how far we are historically, it wouldn't be a surprise if we see the stable release this month (well before the RN 0.74/Yoga 3.0 cut, even in the worse case).

Changelog:
[Android][Changed] - Use NDK 26

Reviewed By: yungsters

Differential Revision: D49895949

fbshipit-source-id: 37bb4d1fdf81137be7f14f6675b4e079c6f861e4

Original-Commit: facebook/react-native@9ce7b56
  • Loading branch information
NickGerleman authored and facebook-github-bot committed Oct 5, 2023
1 parent 066cbfb commit 573e4d2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion template/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ buildscript {
minSdkVersion = 23
compileSdkVersion = 34
targetSdkVersion = 34
ndkVersion = "25.1.8937393"
ndkVersion = "26.0.10792818"
kotlinVersion = "1.8.0"
}
repositories {
Expand Down

0 comments on commit 573e4d2

Please sign in to comment.