Skip to content

Commit 066cbfb

Browse files
NickGerlemanfacebook-github-bot
authored andcommitted
Bump Folly to 2023.08.07.00 (#39798)
Summary: This bumps folly, to absorb facebook/folly@45fffa6 which fixes warnings in XCode 15, and NDK 26 (treated as error bc we have better hygiene there). We then bump a little bit further to get past a new warning added, then fixed later. Need to manually set `FOLLY_HAVE_GETTIME` on Apple because of the silliness described in facebook/folly#1470 (comment) There is not a combination of Folly, and Android libc++, that has fixes for warnings, but doesn't require the new libc++ in NDK 26. It is expected then that this commit will fail the build, but the next should succeed, and the two must be landed at the same time. Changelog: [Internal] Pull Request resolved: facebook/react-native#39798 Reviewed By: fkgozali Differential Revision: D49897681 Pulled By: NickGerleman fbshipit-source-id: 52b97ed5b302abf9e27f38dc655207827852dcc3 Original-Commit: facebook/react-native@aefefdb
1 parent e103dca commit 066cbfb

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

template/ios/HelloWorld.xcodeproj/project.pbxproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -578,6 +578,7 @@
578578
"-DFOLLY_MOBILE=1",
579579
"-DFOLLY_USE_LIBCPP=1",
580580
"-DFOLLY_CFG_NO_COROUTINES=1",
581+
"-DFOLLY_HAVE_CLOCK_GETTIME=1",
581582
);
582583
SDKROOT = iphoneos;
583584
};
@@ -642,6 +643,7 @@
642643
"-DFOLLY_MOBILE=1",
643644
"-DFOLLY_USE_LIBCPP=1",
644645
"-DFOLLY_CFG_NO_COROUTINES=1",
646+
"-DFOLLY_HAVE_CLOCK_GETTIME=1",
645647
);
646648
SDKROOT = iphoneos;
647649
VALIDATE_PRODUCT = YES;

0 commit comments

Comments
 (0)