Fix Usage on README #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently currently the option `--template` already adds the `react-native-template` to the path, and if we use what's on README we will have this path that doesn't exist: https://registry.yarnpkg.com/react-native-template-react-native-template-typescript Changing to just `--template typescript` fixes it.
sibelius
approved these changes
Oct 9, 2019
|
This won't work with the new CLI, see here: #62. |
|
As @emin93 noted this wont' work #62 (comment), I will submit a PR to revert it. You're using the old CI. |
radko93
added a commit
that referenced
this pull request
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Apparently currently the option
--templatealready adds thereact-native-templateto the path, and if we use what's on README we will have this path that doesn't exist:https://registry.yarnpkg.com/react-native-template-react-native-template-typescript
Changing to just
--template typescriptfixes it.Test Plan
What's required for testing (prerequisites)?
Follow the README Usage instructions
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdCHANGELOG.mdexample/App.js)