Skip to content

fix(readme): init script #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2019
Merged

fix(readme): init script #62

merged 1 commit into from
Sep 11, 2019

Conversation

artyorsh
Copy link
Contributor

Currently, npx react-native init MyApp --template react-native-template-typescript throws an error because react-native-cli is trying to fetch react-native-template-react-native-template-typescript, so react-native-template prefix is redundant here

Summary

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Just run the current command explained in README.md to face an issue

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

Currently, `npx react-native init MyApp --template react-native-template-typescript` throws an error because react-native-cli is trying to fetch `react-native-template-react-native-template-typescript`, so `react-native-template` prefix is redundant here
@MateusAndrade MateusAndrade merged commit 844277d into react-native-community:master Sep 11, 2019
@emin93
Copy link
Member

emin93 commented Sep 11, 2019

Oh, the default prefix has been re-added? Good to know and thanks for the PR.

@radko93
Copy link
Collaborator

radko93 commented Sep 11, 2019

Have you tried this? It does not work for me

@artyorsh
Copy link
Contributor Author

I've tried both --template react-native-template-typescript and --template typescript and got only the second one working

Faced the same issue for own templates, so decided to help you

@radko93
Copy link
Collaborator

radko93 commented Sep 11, 2019

I appreciate your help!
But this feature was removed from the CLI two months ago so I will revert this PR.

@artyorsh
Copy link
Contributor Author

artyorsh commented Sep 11, 2019

@radko93 Uh, sorry for the wrong fix then and thanks for the details

@emin93 emin93 mentioned this pull request Oct 10, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants