Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(breaking): use Node 10 as compile target #1072

Merged
merged 3 commits into from
Sep 17, 2020
Merged

chore(breaking): use Node 10 as compile target #1072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81fb988
fix: Update to Node.js LTS 10
wtrocki Mar 25, 2020
6004005
Merge remote-tracking branch 'origin/master' into pr/1072
thymikee Sep 17, 2020
1e80697
bump node to 10 for package and Babel
thymikee Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ defaults: &defaults
working_directory: ~/react-native-cli

executors:
node8:
node10:
<<: *defaults
docker:
- image: circleci/node:8
- image: circleci/node:dubnium
nodelts:
<<: *defaults
docker:
Expand Down Expand Up @@ -68,17 +68,21 @@ commands:

jobs:
setup:
executor: node8
executor: node10
steps:
- install-dependencies
lint:
executor: node8
executor: node10
steps:
- run-lint
unit-tests:
cocoa-pods:
executor: noderuby
steps:
- install-cocoapods
- run-cocoa-pods-tests
unit-tests:
executor: node10
steps:
- run-unit-tests
e2e-tests:
executor: reactnative
Expand Down
2 changes: 1 addition & 1 deletion babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module.exports = {
[
require.resolve('@babel/preset-env'),
{
targets: {node: '8.3'},
targets: {node: '10'},
useBuiltIns: 'entry',
corejs: '2.x',
},
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
],
"engineStrict": true,
"engines": {
"node": ">=8.3"
"node": ">=10"
},
"repository": {
"type": "git",
Expand Down