Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(breaking): use Node 10 as compile target #1072

Merged
merged 3 commits into from
Sep 17, 2020
Merged

chore(breaking): use Node 10 as compile target #1072

merged 3 commits into from
Sep 17, 2020

Conversation

wtrocki
Copy link
Contributor

@wtrocki wtrocki commented Mar 25, 2020 •
edited
Loading

Node 8 is out of the support. 10 and 12 LTS are the latest 2 LTS versions.
Creating PR just to verify if tests will run on Node 10 LTS. I understand that there might be reasons why Node 8 is still used.

List of the supported circle ci images:
https://circleci.com/docs/2.0/circleci-images/#nodejs

Verification

  1. Build passes

@wtrocki
fix: Update to Node.js LTS 10
81fb988 
Node 8 is out of the support
@wtrocki wtrocki changed the title fix: Update to Node.js LTS 10 fix: Update CI tests to run on Node.js LTS 10 Mar 25, 2020
@thymikee
Copy link
Member

thymikee commented Mar 25, 2020 •
edited
Loading

react-native module is still on Node 8, and the closest release, 0.62, is not dropping it yet: https://github.com/facebook/react-native/blob/0.62-stable/package.json#L11-L13.

I'd say we drop it when react-native does, which is 0.63.

@thymikee thymikee added this to the 5.x milestone Apr 15, 2020
@thymikee
Merge remote-tracking branch 'origin/master' into pr/1072
6004005 
* origin/master: (81 commits)
  chore(deps): bump node-fetch from 2.6.0 to 2.6.1 (react-native-community#1267)
  v4.13.0
  chore: remove await in getLatestFile function call from downloadProfile file. (react-native-community#1266)
  Augment react-native info with out of tree platform packages info (react-native-community#1264)
  feat: add a command to download the Hermes Sampling Profiler to a local machine (react-native-community#1246)
  chore(deps): bump lodash from 4.17.15 to 4.17.19 (react-native-community#1221)
  Fix package name for main activity when appId set (react-native-community#1242)
  Just use the users default browser (react-native-community#1257)
  feat: improve progress indicator for iOS builds without xcpretty (react-native-community#1254)
  fix: 🐛 executableFolderPath to run app name in iOS 14.0 (react-native-community#1236)
  chore(deps): bump elliptic from 6.5.2 to 6.5.3 (react-native-community#1233)
  v4.12.0
  Add Windows info to react-native info (react-native-community#1227)
  add new version RN Podfile link, autolinking docs. (react-native-community#1245)
  docs: add linkage instructions for `yarn` v2 (react-native-community#1237)
  v4.11.0
  fix: adjust range on react-native peer dep to support 0.63 (react-native-community#1234)
  chore: update jest config (react-native-community#1241)
  Use new chrome based edge if the user is already running it, and not running chrome (react-native-community#1222)
  Add windows logic to guess the users preferred editor for launchEditor (react-native-community#1216)
  ...
@thymikee
bump node to 10 for package and Babel
1e80697
@thymikee thymikee changed the title fix: Update CI tests to run on Node.js LTS 10 chore(breaking): use Node 10 as compile target Sep 17, 2020
thymikee
thymikee approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we're finally ready to merge :)

@thymikee thymikee merged commit 1bd6552 into react-native-community:master Sep 17, 2020
thymikee added a commit to imoans/cli that referenced this pull request Sep 17, 2020
@thymikee
Merge remote-tracking branch 'origin/master' into pr/1146
885157c 
* origin/master: (47 commits)
  chore(breaking): use Node 10 as compile target (react-native-community#1072)
  chore(deps): bump node-fetch from 2.6.0 to 2.6.1 (react-native-community#1267)
  v4.13.0
  chore: remove await in getLatestFile function call from downloadProfile file. (react-native-community#1266)
  Augment react-native info with out of tree platform packages info (react-native-community#1264)
  feat: add a command to download the Hermes Sampling Profiler to a local machine (react-native-community#1246)
  chore(deps): bump lodash from 4.17.15 to 4.17.19 (react-native-community#1221)
  Fix package name for main activity when appId set (react-native-community#1242)
  Just use the users default browser (react-native-community#1257)
  feat: improve progress indicator for iOS builds without xcpretty (react-native-community#1254)
  fix: 🐛 executableFolderPath to run app name in iOS 14.0 (react-native-community#1236)
  chore(deps): bump elliptic from 6.5.2 to 6.5.3 (react-native-community#1233)
  v4.12.0
  Add Windows info to react-native info (react-native-community#1227)
  add new version RN Podfile link, autolinking docs. (react-native-community#1245)
  docs: add linkage instructions for `yarn` v2 (react-native-community#1237)
  v4.11.0
  fix: adjust range on react-native peer dep to support 0.63 (react-native-community#1234)
  chore: update jest config (react-native-community#1241)
  Use new chrome based edge if the user is already running it, and not running chrome (react-native-community#1222)
  ...
thymikee added a commit that referenced this pull request Sep 17, 2020
@thymikee
Merge remote-tracking branch 'origin/master' into chore/joi-17
ce286fb 
* origin/master:
  chore: update @react-native-community/eslint-config to v2 (#1146)
  chore(breaking): use Node 10 as compile target (#1072)
  chore(deps): bump node-fetch from 2.6.0 to 2.6.1 (#1267)
  v4.13.0
  chore: remove await in getLatestFile function call from downloadProfile file. (#1266)
  Augment react-native info with out of tree platform packages info (#1264)
@wtrocki wtrocki deleted the patch-1 branch September 18, 2020 08:18
@Simek Simek mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

@Esemesek Esemesek Awaiting requested review from Esemesek

@grabbou grabbou Awaiting requested review from grabbou

Assignees
No one assigned
Labels
on hold
Projects
None yet
Milestone
5.x
Development

Successfully merging this pull request may close these issues.
2 participants
@wtrocki @thymikee