Upgrade to latest @figma/plugin-api via a series of other changes #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix error related to stricter types around Promise. - Fix globalThis.parent no longer being set.
- This is the latest version of the npm (and the version we currently use in our monorepo). - To do this, I needed to change the transformer from babel-js to default-esm. - That change required using a formal import for the `jest` global in postmessage.test.ts. - Also, 'constructor' is now returned from Object.getOwnPropertyNames, which seems to align with the es standard. This breaks the applyMixins module, so I rewrote that to use more modern JS syntax and exclude the 'constructor' key.
- Replace usage with EventTarget, which is certainly simpler than rxjs here. - There is potentially a way to have a single global EventTarget for all event types, but this is not yet implemented in this PR.
- Required adding useless stubs for a few new APIs.
applmak
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
|
No problem with me! |
svallory
added a commit
to cva-design/figma-api-stub
that referenced
this pull request
Aug 18, 2023
…inal PR: react-figma#66) (#1) * Upgrade to latest jest & typescript - Fix error related to stricter types around Promise. - Fix globalThis.parent no longer being set. * Upgrade nanoid to 4.x - This is the latest version of the npm (and the version we currently use in our monorepo). - To do this, I needed to change the transformer from babel-js to default-esm. - That change required using a formal import for the `jest` global in postmessage.test.ts. - Also, 'constructor' is now returned from Object.getOwnPropertyNames, which seems to align with the es standard. This breaks the applyMixins module, so I rewrote that to use more modern JS syntax and exclude the 'constructor' key. * Remove use of rxjs - Replace usage with EventTarget, which is certainly simpler than rxjs here. - There is potentially a way to have a single global EventTarget for all event types, but this is not yet implemented in this PR. * Upgrade to latest @figma/plugin-api: - Required adding useless stubs for a few new APIs. --------- Co-authored-by: Matt Handley <applmak@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit descriptions for details.