Skip to content

Upgrade to @figma/plugin-api 1.71 via a series of other changes (Original PR: react-figma#66) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 18, 2023
Merged

Upgrade to @figma/plugin-api 1.71 via a series of other changes (Original PR: react-figma#66) #1

merged 4 commits into from
Aug 18, 2023

Conversation

svallory
Copy link
Member

Original PR: react-figma#66 (Upgrade to latest @figma/plugin-api via a series of other changes)

Changelog

Upgrades dependency versions of

dependency previous version new version
@figma/plugin-typings ^1.42.1 ~1.71.1
@types/jest ^24.0.23 ^29.5.3
jest ^24.9.0 ^29.6.1
ts-jest ^24.2.0 ^29.1.1
typescript 3.5.3 ^5.0.0
nanoid ^3.1.20 ^4.0.2
rxjs ^6.5.3 removed

Build Changes

  • Jest preset "ts-jest/presets/default-esm" instead of "ts-jest/presets/js-with-babel"
  • Changes Typescript output from commonjs to ES6. Here are the changes totsconfig.json:
    setting old value new value
    module commonjs ES6
    target es5 es6
    esModuleInterop false true

applmak added 4 commits July 26, 2023 11:03
@applmak
Upgrade to latest jest & typescript
c82639b 
- Fix error related to stricter types around Promise.
- Fix globalThis.parent no longer being set.
@applmak
Upgrade nanoid to 4.x
fe20bcc 
- This is the latest version of the npm (and the version we currently use in our monorepo).
- To do this, I needed to change the transformer from babel-js to default-esm.
- That change required using a formal import for the `jest` global in postmessage.test.ts.
- Also, 'constructor' is now returned from Object.getOwnPropertyNames, which seems to align with the es standard. This breaks the applyMixins module, so I rewrote that to use more modern JS syntax and exclude the 'constructor' key.
@applmak
Remove use of rxjs
0c78352 
- Replace usage with EventTarget, which is certainly simpler than rxjs here.
- There is potentially a way to have a single global EventTarget for all event types, but this is not yet implemented in this PR.
@applmak
Upgrade to latest @figma/plugin-api:
71d553c 
- Required adding useless stubs for a few new APIs.
@svallory svallory mentioned this pull request Aug 15, 2023
Open
@svallory svallory changed the title Upgrade to latest @figma/plugin-api via a series of other changes (Original PR: #66) Upgrade to latest @figma/plugin-api via a series of other changes [#1] (Original PR: react-figma#66) Aug 18, 2023
@svallory svallory changed the title Upgrade to latest @figma/plugin-api via a series of other changes [#1] (Original PR: react-figma#66) Upgrade to @figma/plugin-api 1.71 via a series of other changes (Original PR: react-figma#66) Aug 18, 2023
@svallory svallory changed the title Upgrade to @figma/plugin-api 1.71 via a series of other changes (Original PR: react-figma#66) Upgrade to @figma/plugin-api 1.71 via a series of other changes (Original PR: react-figma#66) Aug 18, 2023
@svallory svallory merged commit 6a0887e into cva-design:dev Aug 18, 2023
This was referenced Aug 18, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svallory @applmak