Skip to content

fix: fix wrong state #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2020
Merged

fix: fix wrong state #316

merged 1 commit into from
Dec 28, 2020

Conversation

roftLin
Copy link
Contributor

@roftLin roftLin commented Dec 25, 2020

这个组件并没有current状态(可能某个版本删去了),对应的逻辑应该重新调整,更符合实际情况。

这个组件并没有current状态(可能某个版本删去了),对应的逻辑应该重新调整,更符合实际情况。
@vercel
Copy link

vercel bot commented Dec 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/pagination/ckst2jduu
✅ Preview: https://pagination-git-fork-roftlin-patch-1.react-component.vercel.app

@codecov
Copy link

codecov bot commented Dec 25, 2020

Codecov Report

Merging #316 (7b0550c) into master (59f5599) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   91.43%   91.43%           
=======================================
  Files           3        3           
  Lines         327      327           
  Branches      113      113           
=======================================
  Hits          299      299           
  Misses         28       28           
Impacted Files Coverage Δ
src/Options.jsx 93.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59f5599...7b0550c. Read the comment docs.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 25, 2020

This pull request fixes 1 alert when merging 7b0550c into 59f5599 - view on LGTM.com

fixed alerts:

  • 1 for Unused or undefined state property

@yoyo837
Copy link
Member

yoyo837 commented Dec 25, 2020

@afc163 看下他说的这个current, 是不是 #188 里应该使用的props上的current?

@roftLin roftLin closed this Dec 25, 2020
@roftLin roftLin reopened this Dec 25, 2020
@afc163 afc163 mentioned this pull request Dec 25, 2020
@afc163 afc163 merged commit 24e7c2c into react-component:master Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants