Skip to content

fix: fix wrong state #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

roftLin
Copy link
Contributor

@roftLin roftLin commented Dec 25, 2020

这个组件并没有current状态(某个版本改动导致),对应的逻辑应该重新调整,更符合实际情况。

这个组件并没有current状态(某个版本改动导致),对应的逻辑应该重新调整,更符合实际情况。
@vercel
Copy link

vercel bot commented Dec 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/pagination/nkh76j2j1
✅ Preview: https://pagination-git-fork-roftlin-patch-2.react-component.vercel.app

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 25, 2020

This pull request fixes 1 alert when merging 435ebc1 into 59f5599 - view on LGTM.com

fixed alerts:

  • 1 for Unused or undefined state property

@codecov
Copy link

codecov bot commented Dec 25, 2020

Codecov Report

Merging #317 (435ebc1) into master (59f5599) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
+ Coverage   91.43%   91.46%   +0.02%     
==========================================
  Files           3        3              
  Lines         327      328       +1     
  Branches      113      113              
==========================================
+ Hits          299      300       +1     
  Misses         28       28              
Impacted Files Coverage Δ
src/Options.jsx 93.84% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59f5599...435ebc1. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Dec 25, 2020

这个和 #316 哪个是对的?

@yoyo837
Copy link
Member

yoyo837 commented Dec 25, 2020

那要看你 #188 的改动来说

@roftLin
Copy link
Contributor Author

roftLin commented Dec 25, 2020

这个和 #316 哪个是对的?

两种改法都是对的,最后都会去取current。

@roftLin
Copy link
Contributor Author

roftLin commented Dec 25, 2020

这个和 #316 哪个是对的?

还是使用316的吧,毕竟这种情况不应该触发onchange方法😊

@afc163 afc163 closed this Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants