Skip to content

ci: prefer build-and-inspect-python-package over custom solution #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MyPyDavid merged 1 commit into from
Oct 20, 2025
Merged

ci: prefer build-and-inspect-python-package over custom solution #1445

MyPyDavid merged 1 commit into from
Oct 20, 2025

Conversation

@afuetterer
Copy link
Member

@afuetterer afuetterer commented Oct 17, 2025 •
edited
Loading

Description

Related issue: #1089

Motivation and Context

Ref: https://github.com/hynek/build-and-inspect-python-package

How has this been tested?

CI setup has been tested in my fork.

@afuetterer afuetterer requested a review from MyPyDavid October 17, 2025 13:30
@afuetterer afuetterer changed the title ci: prefer build-and-inspect-python-package over custom solution ci: prefer build-and-inspect-python-package over custom solution Oct 17, 2025
@MyPyDavid MyPyDavid changed the base branch from 2.3.3 to dependency-updates October 17, 2025 14:56
@MyPyDavid
Copy link
Member

MyPyDavid commented Oct 17, 2025

should I rebase it to dependency-updates or would you do it?

@afuetterer
Copy link
Member Author

afuetterer commented Oct 17, 2025

Please do. Thanks.

@afuetterer afuetterer added the github_actions Pull requests that update GitHub Actions code label Oct 17, 2025
@MyPyDavid
Copy link
Member

MyPyDavid commented Oct 17, 2025

ok, now the rebase to dependency-updates seems right!

@MyPyDavid MyPyDavid added this to the RDMO 2.3.3 milestone Oct 17, 2025
@afuetterer
Copy link
Member Author

afuetterer commented Oct 18, 2025

I branched from 2.3.3, so there were a few differing commits, I guess. Thanks for rebasing.

@MyPyDavid
Copy link
Member

MyPyDavid commented Oct 20, 2025

yeah, I needed to rebase the dependency-updates first to 2.3.3 as well ;)
I'll merge this then thanks!

@MyPyDavid MyPyDavid merged commit 5bc0b55 into rdmorganiser:dependency-updates Oct 20, 2025
28 of 30 checks passed
@afuetterer afuetterer deleted the 1089-baipp branch October 21, 2025 08:45
@MyPyDavid MyPyDavid linked an issue Oct 21, 2025 that may be closed by this pull request
ci: Investigate switching to build-and-inspect-python-package #1089
Closed
@afuetterer afuetterer mentioned this pull request Oct 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MyPyDavid MyPyDavid MyPyDavid approved these changes

Assignees

No one assigned

Labels

github_actions Pull requests that update GitHub Actions code type:maintenance

Projects

None yet

Milestone

RDMO 2.3.3

Development

Successfully merging this pull request may close these issues.

ci: Investigate switching to build-and-inspect-python-package

2 participants

@afuetterer @MyPyDavid