Skip to content

Conversation

@afuetterer
Copy link
Member

Description

After merging #1445 has been merged, we no longer call build manually in CI. I opt to remove it from dev dependencies then.

Same goes for wheel.

Also let's please remove it from build-system.requires, as per:

Historically this documentation has unnecessarily listed wheel in the requires list, and many projects still do that. This is not recommended, as the backend no longer requires the wheel package, and listing it explicitly causes it to be unnecessarily required for source distribution builds. You should only include wheel in requires if you need to explicitly access it during build time (e.g. if your project needs a setup.py script that imports wheel).

Ref: Second note under https://setuptools.pypa.io/en/latest/userguide/quickstart.html#basic-use

Motivation and Context

How has this been tested?

Screenshots (if appropriate)

Copy link
Member

@MyPyDavid MyPyDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that looks like a good clean up, thanks for keeping it up to date @afuetterer!
I'm so glad that we're not using setup.py anymore :P

@MyPyDavid MyPyDavid merged commit 22e622f into rdmorganiser:dependency-updates Oct 21, 2025
18 checks passed
@MyPyDavid MyPyDavid added this to the RDMO 2.3.3 milestone Oct 21, 2025
@afuetterer afuetterer deleted the wheel branch October 21, 2025 13:19
@jochenklar
Copy link
Member

Hmm, I think we use build and wheel when we do the actual releases ...

@afuetterer
Copy link
Member Author

I did not realize that. Sorry. Revert this commit / PR?

You mean this?

subprocess.call(['/bin/bash', '-c', f'{sys.executable} -m build'])

You call build there, alright. Fair point. But wheel is not needed, as per quote above.

Also in my opinion, if you have a build command in rdmo-admin, that is no dev dependency, right? You ship that command to users of rdmo as well. They probably will never call rdmo-admin build, but it would fail without installing rdmo[dev].

Is it a solution to put build in the main dependencies then? I don't know.

@jochenklar
Copy link
Member

Good point about the rdmo-admin tool. I think usually tools fail then with a usefull message. Lets keep it like it is now and we will just see what happens in the new release. dev was kind of a convenience package for me anyway.

@afuetterer
Copy link
Member Author

afuetterer commented Oct 22, 2025

Quick followup: Without build in dev I get this, which makes sense.

$ rdmo-admin build
/rdmo/.venv/bin/python3: No module named build.__main__; 'build' is a package and cannot be directly executed

Adding build manually to the venv, lets the command pass.

  • wheel is not needed, to build the package (wheel) succesfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants