Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCS] No need to send actor death signal from gcs client #7883

Merged
merged 2 commits into from
Apr 4, 2020
Merged

[GCS] No need to send actor death signal from gcs client #7883

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc3a747
rm actor died signal from RedisActorInfoAccessor
micafan Apr 3, 2020
b50ff4f
Merge branch 'master' into rm_actor_died_signal_from_gcs_client
micafan Apr 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/ray/gcs/redis_accessor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,16 +101,6 @@ Status RedisLogBasedActorInfoAccessor::AsyncUpdate(
<< ", actor id: " << actor_id << ", log_length: " << log_length;
auto on_success = [callback](RedisGcsClient *client, const ActorID &actor_id,
const ActorTableData &data) {
// If we successfully appended a record to the GCS table of the actor that
// has died, signal this to anyone receiving signals from this actor.
if (data.state() == ActorTableData::DEAD ||
data.state() == ActorTableData::RECONSTRUCTING) {
std::vector<std::string> args = {"XADD", actor_id.Hex(), "*", "signal",
"ACTOR_DIED_SIGNAL"};
auto redis_context = client->primary_context();
RAY_CHECK_OK(redis_context->RunArgvAsync(args));
}

if (callback != nullptr) {
callback(Status::OK());
}
Expand Down