Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCS] No need to send actor death signal from gcs client #7883

Conversation

micafan
Copy link
Contributor

@micafan micafan commented Apr 3, 2020

GCS Client will send actor died signal to notify python worker that an actor has dead. It seems that python worker does not need this signal now, so GCS Client can remove these signal logic.

Related issue number

#7675

Checks

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@mehrdadn
Copy link
Contributor

mehrdadn commented Apr 3, 2020

Thanks!! Before we merge this, I'll try to see if I can get it working on Windows. It doesn't seem to run as-is yet. (It fails to connect to Redis at all.) Never mind, it's working fine, I was making a mistake somewhere when testing :) thanks!

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/24172/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/24190/
Test PASSed.

@robertnishihara robertnishihara merged commit 185d591 into ray-project:master Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants