Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCS] Use new interface class GcsClient in ray #6805

Merged
merged 7 commits into from
Jan 17, 2020
Merged

[GCS] Use new interface class GcsClient in ray #6805

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3e73c73
modify redis gcs client usage of raylet and core worker
micafan Jan 16, 2020
6db2206
modify UT usage
micafan Jan 16, 2020
6170c14
rm friend class of RedisGcsClient
micafan Jan 16, 2020
bbd4a59
update comments of RedisGcsClient
micafan Jan 16, 2020
a9d4603
add override to RedisGcsClient methods
micafan Jan 16, 2020
9796b8f
Merge branch 'master' into replace_redis_gcs_client_with_gcs_client
micafan Jan 16, 2020
76ffc1f
fix comment
micafan Jan 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add override to RedisGcsClient methods
  • Loading branch information
@micafan
micafan committed Jan 16, 2020
commit a9d460300d8cf1f58858080c57bec62bf9240070
6 changes: 3 additions & 3 deletions src/ray/gcs/redis_gcs_client.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,15 @@ class RAY_EXPORT RedisGcsClient : public GcsClient {
/// Must be single-threaded io_service (get more information from RedisAsioClient).
///
/// \return Status
Status Connect(boost::asio::io_service &io_service);
Status Connect(boost::asio::io_service &io_service) override;

/// Disconnect with GCS Service. Non-thread safe.
void Disconnect();
void Disconnect() override;

/// Returns debug string for class.
///
/// \return string.
std::string DebugString() const;
std::string DebugString() const override;

// We also need something to export generic code to run on workers from the
// driver (to set the PYTHONPATH)
Expand Down