[GCS] Use new interface class GcsClient in ray #6805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Test FAILed. |
|
Test FAILed. |
stephanie-wang
approved these changes
Jan 16, 2020
src/ray/gcs/redis_gcs_client.h
Outdated
|
|
||
| /// The following three methods will be deprecated, use method Actors() instead. | ||
| /// The following xxx_table methods is no longer used as interface, | ||
| /// just used as implementation. |
There was a problem hiding this comment.
Suggested change
| /// just used as implementation. | |
| /// The following xxx_table methods implement the Accessor interfaces. |
src/ray/gcs/redis_gcs_client.h
Outdated
| /// The following three methods will be deprecated, use method Actors() instead. | ||
| /// The following xxx_table methods is no longer used as interface, | ||
| /// just used as implementation. | ||
| /// Use new interface method Actors() instead of the following three methods. |
There was a problem hiding this comment.
Suggested change
| /// Use new interface method Actors() instead of the following three methods. | |
| /// Implements the Actors() interface. |
Same for below.
|
Test FAILed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Use GcsClient instead of RedisGcsClient in ray.
Related issue number
Closes #5058
Checks
scripts/format.shto lint the changes in this PR.