cleanup(ci): don't set default MANYLINUX_VERSION build_arg #60540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Reviews in this chain: |
This was referenced Jan 27, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the hardcoded default MANYLINUX_VERSION from several CI configuration files. By relying on a single source of truth from the environment (rayci.env), this change improves maintainability and consistency. The refactoring is applied correctly and consistently across all relevant files. This is a good cleanup.
Base automatically changed from
andrew/revup/master/rayci-envfile-27
to
master
January 27, 2026 21:46
andrew-anyscale
force-pushed
the
andrew/revup/master/cleanup-manylinux
branch
from
2691a36 to
92674ad
Compare
Now handled in single source of truth at rayci.env. That envfile should be the only placeholder we update. Topic: cleanup-manylinux Relative: rayci-envfile-27 Signed-off-by: andrew <andrew@anyscale.com>
andrew-anyscale
force-pushed
the
andrew/revup/master/cleanup-manylinux
branch
from
92674ad to
40ef209
Compare
aslonnie
approved these changes
Jan 27, 2026
aslonnie
approved these changes
Jan 27, 2026
limarkdcunha
pushed a commit
to limarkdcunha/ray
that referenced
this pull request
Jan 29, 2026
…ct#60540) Now handled in single source of truth at rayci.env. That envfile should be the only placeholder we update. Topic: cleanup-manylinux Relative: rayci-envfile-27 Signed-off-by: andrew <andrew@anyscale.com> Signed-off-by: andrew <andrew@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now handled in single source of truth at rayci.env. That envfile should be the only placeholder we update.
Topic: cleanup-manylinux
Relative: rayci-envfile-27
Signed-off-by: andrew andrew@anyscale.com