Skip to content

Conversation

@andrew-anyscale
Copy link
Contributor

@andrew-anyscale andrew-anyscale commented Jan 23, 2026

Updates buildkite steps to use Wanda+Dockerfile, including both build and upload steps.
For now, missing parity on uploading pip-freeze to Buildkite Artifacts. To be done in subsequent Wanda feature

Topic: wanda-image-upload
Relative: multiplat-support
Signed-off-by: andrew andrew@anyscale.com

@andrew-anyscale
Copy link
Contributor Author

andrew-anyscale commented Jan 23, 2026

Reviews in this chain:
#60455 [ci] port Buildkite Ray Images to Wanda
 ├#59937 [ci] Add wanda anyscale image builds for release tests
 └#60539 Consolidate RAY_VERSION to use rayci.env as single source of truth

@andrew-anyscale
Copy link
Contributor Author

andrew-anyscale commented Jan 23, 2026

# head base diff date summary
0 3a35fdb6 9d5c113a diff Jan 23 8:54 AM 2 files changed, 476 insertions(+), 79 deletions(-)
1 1d0a962d 7d33f916 diff Jan 26 9:02 AM 1 file changed, 7 insertions(+)
2 1960a8e6 8808ad90 diff Jan 27 9:45 AM 3 files changed, 11 insertions(+), 10 deletions(-)
3 6cfc4e79 3813b4f8 diff Jan 27 9:48 AM 0 files changed
4 d1a8111b 3813b4f8 diff Jan 27 9:50 AM 1 file changed, 1 insertion(+)
5 a4fe1e01 c9b78801 diff Jan 27 13:56 PM 0 files changed
6 8ed4a6d1 23402617 diff Jan 29 16:22 PM 1 file changed, 8 insertions(+)
7 2d70aa81 17c6070f diff Jan 29 16:45 PM 1 file changed, 1 insertion(+), 1 deletion(-)
8 869f34fb 17c6070f diff Jan 29 16:47 PM 1 file changed, 1 insertion(+)
9 536ab35d 17c6070f diff Jan 29 17:00 PM 1 file changed, 1 insertion(+)
10 2abbbc5e 17c6070f diff Jan 29 17:51 PM 2 files changed, 1 insertion(+), 2 deletions(-)
11 45cd1ae4 dcfc8098 diff Jan 29 18:33 PM 0 files changed
12 6ed02db2 d0e66729 rebase Jan 29 21:00 PM 0 files changed
13 e4774330 53801907 rebase Jan 29 21:03 PM 0 files changed
14 ad559443 53801907 diff Jan 29 21:20 PM 1 file changed, 1 insertion(+), 1 deletion(-)
15 c663c716 f3f1afc3 diff Jan 30 8:58 AM 4 files changed, 298 insertions(+), 181 deletions(-)
16 5af6a2b9 22702c04 rebase Jan 30 9:07 AM 0 files changed
17 907e1ec1 68188ccb diff Jan 30 10:19 AM 2 files changed, 6 insertions(+), 18 deletions(-)
18 f2086dc7 68188ccb diff Jan 30 10:41 AM 1 file changed, 3 insertions(+), 1 deletion(-)
19 b66d7595 7452f4cf rebase Jan 30 10:46 AM 0 files changed
20 2fb5892f 54061a8c diff Jan 30 10:58 AM 0 files changed
21 efba4b0f 9fc08d89 rebase Jan 30 10:59 AM 0 files changed
22 cba45eb4 aa87d9de rebase Jan 30 12:22 PM 0 files changed
23 ba9c8603 c6a71b7e diff Jan 30 13:28 PM 2 files changed, 6 insertions(+)
24 fc730b06 86e7fb92 rebase Jan 30 13:31 PM 0 files changed
25 1609eac2 aa0695a8 diff Jan 30 13:58 PM 2 files changed, 6 insertions(+)
26 1609eac2 aa0695a8 diff Jan 30 13:59 PM 0 files changed
27 7fe9ae2b 2b490725 rebase Jan 30 14:21 PM 0 files changed
28 0ec84ea3 44aa52e6 rebase Jan 30 15:13 PM 0 files changed
29 ea2ca724 3e40294d diff Jan 30 17:26 PM 0 files changed

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Ray image build process in Buildkite to use Wanda. The changes separate the build and push steps for Docker images, which is a good improvement. The new Wanda-based build steps are defined in new .wanda.yaml files, and the Buildkite pipelines are updated to use them.

My review focuses on the maintainability of the Buildkite configuration files. I've noticed significant duplication of matrix definitions for Python and CUDA versions across different steps. I've suggested using YAML anchors to reduce this redundancy, which will make future updates to these versions much easier and less error-prone. Overall, the changes look good and are a positive step towards a more modular CI process.

Base automatically changed from andrew/revup/master/ray-image to master January 24, 2026 00:41
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/wanda-image-upload branch from 3a35fdb to 1d0a962 Compare January 26, 2026 17:03
@andrew-anyscale andrew-anyscale changed the base branch from master to andrew/revup/master/rayci-envfile January 27, 2026 17:45
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/wanda-image-upload branch from 1d0a962 to 1960a8e Compare January 27, 2026 17:45
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/wanda-image-upload branch from 1960a8e to 6cfc4e7 Compare January 27, 2026 17:49
@andrew-anyscale andrew-anyscale changed the base branch from andrew/revup/master/rayci-envfile to andrew/revup/master/rayci-envfile-27 January 27, 2026 17:49
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/wanda-image-upload branch from 6cfc4e7 to d1a8111 Compare January 27, 2026 17:50
Base automatically changed from andrew/revup/master/rayci-envfile-27 to master January 27, 2026 21:46
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/wanda-image-upload branch from d1a8111 to a4fe1e0 Compare January 27, 2026 21:56
@andrew-anyscale andrew-anyscale changed the title feat(ci): port Buildkite Ray Images to Wanda [ci]: port Buildkite Ray Images to Wanda Jan 30, 2026
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/wanda-image-upload branch from a4fe1e0 to 8ed4a6d Compare January 30, 2026 00:22
@andrew-anyscale andrew-anyscale marked this pull request as ready for review January 30, 2026 00:22
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/wanda-image-upload branch 3 times, most recently from 869f34f to 536ab35 Compare January 30, 2026 01:00
@ray-gardener ray-gardener bot added the devprod label Jan 30, 2026
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/wanda-image-upload branch from 536ab35 to 2abbbc5 Compare January 30, 2026 01:51
@andrew-anyscale andrew-anyscale marked this pull request as draft January 30, 2026 01:51
@andrew-anyscale andrew-anyscale changed the base branch from andrew/revup/master/upload-guards to andrew/revup/master/auth-refactor January 30, 2026 18:19
@andrew-anyscale andrew-anyscale marked this pull request as ready for review January 30, 2026 18:41
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/wanda-image-upload branch from 907e1ec to f2086dc Compare January 30, 2026 18:41
@andrew-anyscale andrew-anyscale requested a review from a team as a code owner January 30, 2026 18:41
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/auth-refactor branch from 68188cc to 7452f4c Compare January 30, 2026 18:46
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/wanda-image-upload branch from f2086dc to b66d759 Compare January 30, 2026 18:46
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/auth-refactor branch from 7452f4c to 54061a8 Compare January 30, 2026 18:58
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/wanda-image-upload branch 2 times, most recently from 2fb5892 to efba4b0 Compare January 30, 2026 18:59
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/auth-refactor branch from 54061a8 to 9fc08d8 Compare January 30, 2026 18:59
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/wanda-image-upload branch from efba4b0 to cba45eb Compare January 30, 2026 20:22
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/auth-refactor branch 2 times, most recently from aa87d9d to c6a71b7 Compare January 30, 2026 21:28
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/wanda-image-upload branch from cba45eb to ba9c860 Compare January 30, 2026 21:28
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/auth-refactor branch from c6a71b7 to 86e7fb9 Compare January 30, 2026 21:31
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/wanda-image-upload branch 2 times, most recently from fc730b0 to 9373b7b Compare January 30, 2026 21:58
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/auth-refactor branch from 86e7fb9 to 6f67b57 Compare January 30, 2026 21:58
@andrew-anyscale andrew-anyscale changed the title [ci]: port Buildkite Ray Images to Wanda [ci] port Buildkite Ray Images to Wanda Jan 30, 2026
@andrew-anyscale andrew-anyscale changed the base branch from andrew/revup/master/auth-refactor to andrew/revup/master/multiplat-support January 30, 2026 21:58
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/wanda-image-upload branch from 9373b7b to 1609eac Compare January 30, 2026 21:59
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/multiplat-support branch 2 times, most recently from aa0695a to 2b49072 Compare January 30, 2026 22:21
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/wanda-image-upload branch 2 times, most recently from 7fe9ae2 to 0ec84ea Compare January 30, 2026 23:13
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/multiplat-support branch from 2b49072 to 44aa52e Compare January 30, 2026 23:13
Base automatically changed from andrew/revup/master/multiplat-support to master January 31, 2026 00:56
Updates buildkite steps to use Wanda+Dockerfile, including both build and upload steps.
For now, missing parity on uploading pip-freeze to Buildkite Artifacts. To be done in subsequent Wanda feature

Topic: wanda-image-upload
Relative: multiplat-support
Signed-off-by: andrew <andrew@anyscale.com>
@andrew-anyscale andrew-anyscale force-pushed the andrew/revup/master/wanda-image-upload branch from 0ec84ea to ea2ca72 Compare January 31, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci devprod go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants