-
Notifications
You must be signed in to change notification settings - Fork 7.2k
[ci] port Buildkite Ray Images to Wanda #60455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the Ray image build process in Buildkite to use Wanda. The changes separate the build and push steps for Docker images, which is a good improvement. The new Wanda-based build steps are defined in new .wanda.yaml files, and the Buildkite pipelines are updated to use them.
My review focuses on the maintainability of the Buildkite configuration files. I've noticed significant duplication of matrix definitions for Python and CUDA versions across different steps. I've suggested using YAML anchors to reduce this redundancy, which will make future updates to these versions much easier and less error-prone. Overall, the changes look good and are a positive step towards a more modular CI process.
3a35fdb to
1d0a962
Compare
1d0a962 to
1960a8e
Compare
1960a8e to
6cfc4e7
Compare
6cfc4e7 to
d1a8111
Compare
d1a8111 to
a4fe1e0
Compare
a4fe1e0 to
8ed4a6d
Compare
869f34f to
536ab35
Compare
536ab35 to
2abbbc5
Compare
907e1ec to
f2086dc
Compare
68188cc to
7452f4c
Compare
f2086dc to
b66d759
Compare
7452f4c to
54061a8
Compare
2fb5892 to
efba4b0
Compare
54061a8 to
9fc08d8
Compare
efba4b0 to
cba45eb
Compare
aa87d9d to
c6a71b7
Compare
cba45eb to
ba9c860
Compare
c6a71b7 to
86e7fb9
Compare
fc730b0 to
9373b7b
Compare
86e7fb9 to
6f67b57
Compare
9373b7b to
1609eac
Compare
aa0695a to
2b49072
Compare
7fe9ae2 to
0ec84ea
Compare
2b49072 to
44aa52e
Compare
Updates buildkite steps to use Wanda+Dockerfile, including both build and upload steps. For now, missing parity on uploading pip-freeze to Buildkite Artifacts. To be done in subsequent Wanda feature Topic: wanda-image-upload Relative: multiplat-support Signed-off-by: andrew <andrew@anyscale.com>
0ec84ea to
ea2ca72
Compare
Updates buildkite steps to use Wanda+Dockerfile, including both build and upload steps.
For now, missing parity on uploading pip-freeze to Buildkite Artifacts. To be done in subsequent Wanda feature
Topic: wanda-image-upload
Relative: multiplat-support
Signed-off-by: andrew andrew@anyscale.com