Change API for remote function declaration, actor instantiation, and actor method invocation. #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

pcmoritz merged 14 commits into ray-project:master from robertnishihara:apichanges

May 14, 2017

Collaborator

robertnishihara commented May 11, 2017 •

edited

Loading

This is intended to resolve #525. Note that this changes the API, so everyone's code will break when this is merged.

This PR changes the API so that

Remote functions are declared with @ray.task and invoked with f.remote(). (Previously they were declared with @ray.remote.)
Actor classes are declared with @ray.actor and instantiated with Class.remote(). (Previously they were instantiated with Class().)
Actor methods are invoked with object.method.remote(). (Previously they were invoked with object.method().)

robertnishihara added 6 commits

May 11, 2017 13:41


          Direction substitution of @ray.remote -> @ray.task.

92a1185


          Changes to make '@ray.task' work.

b6d50b9


          Instantiate actors with Class.remote() instead of Class().


          Convert actor instantiation in tests and examples from Class() to Cla…

da65fd7

…ss.remote().


          Change actor method invocation from object.method() to object.method.…

616015d

…remote().


          Update tests and examples to invoke actor methods with .remote().

438f013

robertnishihara mentioned this pull request

Resolving inconsistencies in the API. #525

Closed

AmplabJenkins commented May 11, 2017

Merged build finished. Test FAILed.

AmplabJenkins commented May 11, 2017

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/731/
Test FAILed.


          Fix bugs in jenkins tests.

b4dfb67

AmplabJenkins commented May 12, 2017

Merged build finished. Test PASSed.

AmplabJenkins commented May 12, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/732/
Test PASSed.


          Fix example applications.

43e2c60

AmplabJenkins commented May 12, 2017

Merged build finished. Test PASSed.

AmplabJenkins commented May 12, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/735/
Test PASSed.

robertnishihara added 4 commits

May 12, 2017 18:31


          Change @ray.task back to @ray.remote.

2164b02


          Changes to make @ray.actor -> @ray.remote work.

878abd6


          Direct substitution of @ray.actor -> @ray.remote.

fa1cc35


          Fixes.

37c2ebe

AmplabJenkins commented May 13, 2017

Merged build finished. Test PASSed.

AmplabJenkins commented May 13, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/756/
Test PASSed.

AmplabJenkins commented May 13, 2017

Merged build finished. Test PASSed.

AmplabJenkins commented May 13, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/757/
Test PASSed.


          Raise exception if @ray.actor decorator is used.

AmplabJenkins commented May 14, 2017

Merged build finished. Test PASSed.

AmplabJenkins commented May 14, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/759/
Test PASSed.


          Simplify ActorMethod class.

105dcd9

AmplabJenkins commented May 14, 2017

Merged build finished. Test PASSed.

AmplabJenkins commented May 14, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/760/
Test PASSed.

pcmoritz merged commit 9f91eb8 into ray-project:master

pcmoritz deleted the apichanges branch

May 14, 2017 07:01

robertnishihara mentioned this pull request

Update to reflect API changes. ray-project/tutorial#25

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet