Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sys.exit(1) to raise in autoscaler update ssh_cmd #5266

Conversation

hartikainen
Copy link
Contributor

What do these changes do?

Changes sys.exit(1) to raise in autoscaler update ssh_cmd, in order to avoid premature exit on updater uptime command. Uptime command sometimes expects an error and doing sys.exit() prevents it from running correctly.

Related issue number

#5265

Linter

  • I've run scripts/format.sh to lint the changes in this PR.

@hartikainen
Copy link
Contributor Author

cc @richardliaw

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15624/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/1798/
Test FAILed.

allocate_tty=True,
expect_error=expect_error,
port_forward=port_forward)
updater.ssh_cmd(cmd, allocate_tty=True, port_forward=port_forward)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exit_on_fail=True

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15666/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15667/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15694/
Test FAILed.

@richardliaw
Copy link
Contributor

@hartikainen can you review and merge? Tests should pass this time around.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15713/
Test FAILed.

@ericl
Copy link
Contributor

ericl commented Jul 27, 2019

Let's hold this since the release is so near (I have a straightforward revert here: #5299)

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15718/
Test FAILed.

@richardliaw richardliaw merged commit 1345802 into ray-project:master Jul 31, 2019
edoakes pushed a commit to edoakes/ray that referenced this pull request Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants