-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change sys.exit(1) to raise in autoscaler update ssh_cmd #5266
Change sys.exit(1) to raise in autoscaler update ssh_cmd #5266
Conversation
cc @richardliaw |
Test FAILed. |
Test FAILed. |
python/ray/autoscaler/commands.py
Outdated
allocate_tty=True, | ||
expect_error=expect_error, | ||
port_forward=port_forward) | ||
updater.ssh_cmd(cmd, allocate_tty=True, port_forward=port_forward) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exit_on_fail=True
Test PASSed. |
Test PASSed. |
Test FAILed. |
@hartikainen can you review and merge? Tests should pass this time around. |
Test FAILed. |
Let's hold this since the release is so near (I have a straightforward revert here: #5299) |
Test FAILed. |
What do these changes do?
Changes
sys.exit(1)
toraise
in autoscaler update ssh_cmd, in order to avoid premature exit on updater uptime command. Uptime command sometimes expects an error and doingsys.exit()
prevents it from running correctly.Related issue number
#5265
Linter
scripts/format.sh
to lint the changes in this PR.