[autoscaler] uptime command fails due to exit(1)

[hartikainen]

System information

• OS Platform and Distribution (e.g., Linux Ubuntu 16.04): 18.04
• Ray installed from (source or binary): source @ 60f5963
• Ray version:
• Python version: 3.7
• Exact command to reproduce: n/a

Describe the problem

Autoscaler sporadically fails when calling uptime. This is caused by the change in #5238 where we tried to clean up the autoscaler error messages. The change works generally fine, but for the uptime command we actually do need to raise instead of exiting because the error is expected to be caught on a higher level.

[richardliaw]

Turns out if you raise click.ClickException, you don't show a huge stack trace but you also raise an exception.

[richardliaw]

Closing this issue for now as we've resolved this with #5266. Honestly, this isn't going to be sustainable unless we have a nice testing framework for this.