Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add compilation warning options #49804

Merged
merged 4 commits into from
Jan 14, 2025
Merged

[core] Add compilation warning options #49804

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41d04cb
Add compilation warning options
dentiny Jan 13, 2025
53013b7
move to front
dentiny Jan 13, 2025
59a4c43
Merge branch 'master' into hjiang/add-more-useful-compilation-options
dentiny Jan 13, 2025
4076f16
Merge branch 'master' into hjiang/add-more-useful-compilation-options
dentiny Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion bazel/ray.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ COPTS_WITHOUT_LOG = select({
"-Wno-microsoft-unqualified-friend", # This shouldn't normally be enabled, but otherwise we get: google/protobuf/map_field.h: warning: unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier (for: friend class DynamicMessage)
],
"//conditions:default": [],
})
}) + [
"-Wunused-result",
"-Wconversion-null",
]

COPTS = COPTS_WITHOUT_LOG

Expand Down