[core] Add compilation warning options #49804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dentiny <dentinyhao@gmail.com>
rynewang
reviewed
Jan 13, 2025
rynewang
approved these changes
Jan 13, 2025
Signed-off-by: dentiny <dentinyhao@gmail.com>
|
|
|
this is breaking windows build. I am reverting. |
aslonnie
added a commit
that referenced
this pull request
Jan 14, 2025
srinathk10
pushed a commit
that referenced
this pull request
Feb 2, 2025
Add two useful compilation options. How I tested: I intentionally break the warning (i.e. define an unused variable), and make sure compilation fails. --------- Signed-off-by: dentiny <dentinyhao@gmail.com>
srinathk10
pushed a commit
that referenced
this pull request
Feb 2, 2025
anyadontfly
pushed a commit
to anyadontfly/ray
that referenced
this pull request
Feb 13, 2025
Add two useful compilation options. How I tested: I intentionally break the warning (i.e. define an unused variable), and make sure compilation fails. --------- Signed-off-by: dentiny <dentinyhao@gmail.com> Signed-off-by: Puyuan Yao <williamyao034@gmail.com>
anyadontfly
pushed a commit
to anyadontfly/ray
that referenced
this pull request
Feb 13, 2025
Reverts ray-project#49804 Signed-off-by: Puyuan Yao <williamyao034@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two useful compilation options.
How I tested: I intentionally break the warning (i.e. define an unused variable), and make sure compilation fails.