Simplify resource bookkeeping in local scheduler. #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
pcmoritz
reviewed
Apr 28, 2017
| /** The number of CPUs that the worker is currently using. This will only be | ||
| * nonzero when the worker is actively executing a task. If the worker is | ||
| * blocked, then this value will be zero. */ | ||
| int cpus_in_use; |
There was a problem hiding this comment.
This should be a double, right?
pcmoritz
reviewed
Apr 28, 2017
| * is not an actor, this will be constant for the duration of a task and will | ||
| * have length equal to the number of GPUs requested by the task (in | ||
| * particular it will not change if the task blocks). */ | ||
| int gpus_in_use; |
There was a problem hiding this comment.
I'm about to turn this into a std::vector<int> in the next PR (which still won't support fractional CPUs and GPUs just yet).
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks off a small self-contained piece of #403.
Note this also makes a couple changes so that local schedulers do not do bookkeeping for resources for actor tasks.