Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Make get_task() accept ObjectRef #43507

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

hongchaodeng
Copy link
Member

Why are these changes needed?

Related issue number

Closes #41307

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@hongchaodeng hongchaodeng requested a review from rickyyx February 28, 2024 18:35
@hongchaodeng hongchaodeng changed the title Feat gettask [core] get_task() accepts ObjectRef Feb 28, 2024
@hongchaodeng hongchaodeng changed the title [core] get_task() accepts ObjectRef [core] Make get_task() accept ObjectRef Mar 5, 2024
@hongchaodeng hongchaodeng self-assigned this Mar 6, 2024
Signed-off-by: max-509 <123456vershinin@gmail.com>
Signed-off-by: hongchaodeng <hongchaodeng1@gmail.com>
@hongchaodeng hongchaodeng requested a review from rkooo567 March 7, 2024 08:21
@rickyyx rickyyx self-assigned this Mar 7, 2024
Copy link
Contributor

@rickyyx rickyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


via Trolli on GIPHY

@rickyyx rickyyx merged commit e9a661d into ray-project:master Mar 7, 2024
9 checks passed
@hongchaodeng hongchaodeng deleted the feat-gettask branch March 7, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] Ray state API get_task() should accept ObjectRef
3 participants