[core] Add possibility to pass ObjectRef to get_task #41611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: max-509 <123456vershinin@gmail.com>
|
@max-509 Would you update the PR: 1. fix lint check; 2. rebase master? |
| assert f_task["node_id"] == node_id | ||
| assert f_task["actor_id"] is None | ||
|
|
||
| assert put_task is None |
There was a problem hiding this comment.
It makes no sense to test this put_task. Please remove it.
| @@ -2417,6 +2417,35 @@ def verify(): | |||
| print(list_tasks()) | |||
|
|
|||
|
|
|||
| def test_get_task_object_ref(shutdown_only): | |||
There was a problem hiding this comment.
We should combine the test of objectRef into test_list_get_tasks()
|
Since we haven't heard from you, I have cherry pick your commit and make another PR with the commented changes: #43507 Let me know if you still want to work on this. Thanks for your contribution and good will! |
anyscalesam
added
stale
|
@hongchaodeng Hello! I think you can close my PR and finish this task in your PR. |
stale
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Prior to these changes to pass task id to
get_task()function user needs to callobject_ref.task_id().hex()which is quite painful. This PR adds possibility to pass ObjectRef toget_task()function.Related issue number
Closes #41307
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.