Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1] add release build to postmerge #42621

Merged
merged 2 commits into from
Jan 30, 2024
Merged

[release/1] add release build to postmerge #42621

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbe74e6
[release] add release build to postmerge
can-anyscale Jan 23, 2024
ba27176
[release/2] add microbenchmark.aws release test to postmerge (#42625)
can-anyscale Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[release] add release build to postmerge 
Signed-off-by: can <can@anyscale.com>
  • Loading branch information
@can-anyscale
can-anyscale committed Jan 25, 2024
commit cbe74e6a65934ed81e2edd072f61e8186e066684
8 changes: 7 additions & 1 deletion .buildkite/release/build.rayci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
group: build
group: release build
steps:
- label: ":tapioca: build: anyscale py{{matrix.python}}-{{matrix.platform}} docker"
tags: skip-on-premerge
key: anyscalebuild
instance_type: release
commands:
- bazel run //ci/ray_ci:build_in_docker -- anyscale
--python-version {{matrix.python}} --platform {{matrix.platform}}
Expand All @@ -22,6 +25,9 @@ steps:
- cpu

- label: ":tapioca: build: anyscale-ml py{{matrix}}-cu11.8.0 docker"
tags: skip-on-premerge
key: anyscalemlbuild
instance_type: release
commands:
Comment on lines +28 to +30
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is exposing anyscale image building on ray postmerge now, which does not feel quite right.

maybe we can just have a per commit build on release test pipeline? or maybe a release-perf pipeline?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postmerge probably should also be private; the fact that someone can create a PR and run it on postmerge (through a new build) and postmerge has right access also does not seem right

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someone can create a PR and run it on postmerge

only authorized members in the buildkite org can launch manual runs. but the results are public, so any one can see it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any strong opinion if I ask in #opensource to see if we can make it private; I'm leaning toward a direction of less number of pipelines if we can rather than more

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm.. you can ask, I don't think people would prefer to make postmerge private though. I think people prefer to maintain an open posture and keep things transparent.

at least there are cases where people need to goto the pipeline and find the wheel that is built for the commit.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let me ask around ;)

- bazel run //ci/ray_ci:build_in_docker -- anyscale --python-version {{matrix}}
--platform cu11.8.0 --image-type ray-ml --upload
Expand Down
2 changes: 1 addition & 1 deletion .buildkite/release/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ forge_prefix: cr.ray.io/rayproject/
builder_queues:
builder: builder_queue_branch
runner_queues:
default: release_queue_small
release: release_queue_small
can-anyscale marked this conversation as resolved.
Show resolved Hide resolved
buildkite_dirs:
- .buildkite/release
env:
Expand Down
1 change: 1 addition & 0 deletions .buildkite/releasebuild.rayci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
release/build.rayci.yml
Loading