-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/1] add release build to postmerge #42621
Conversation
3744747
to
4d595c4
Compare
tags: skip-on-premerge | ||
key: anyscalemlbuild | ||
instance_type: release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is exposing anyscale image building on ray postmerge now, which does not feel quite right.
maybe we can just have a per commit build on release test pipeline? or maybe a release-perf
pipeline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
postmerge probably should also be private; the fact that someone can create a PR and run it on postmerge (through a new build) and postmerge has right access also does not seem right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
someone can create a PR and run it on postmerge
only authorized members in the buildkite org can launch manual runs. but the results are public, so any one can see it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any strong opinion if I ask in #opensource to see if we can make it private; I'm leaning toward a direction of less number of pipelines if we can rather than more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm.. you can ask, I don't think people would prefer to make postmerge private though. I think people prefer to maintain an open posture and keep things transparent.
at least there are cases where people need to goto the pipeline and find the wheel that is built for the commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, let me ask around ;)
4d595c4
to
caf650b
Compare
Signed-off-by: can <can@anyscale.com>
caf650b
to
cbe74e6
Compare
pending switching postmerge to private ;) |
Add the microbenchmark.aws in postmerge Signed-off-by: can <can@anyscale.com>
Add release builds to postmerge. This is part of the work to run postmerge + release tests together in one commit.
Test: