Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1] add release build to postmerge #42621

Merged
merged 2 commits into from
Jan 30, 2024
Merged

[release/1] add release build to postmerge #42621

merged 2 commits into from
Jan 30, 2024

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Jan 23, 2024

Add release builds to postmerge. This is part of the work to run postmerge + release tests together in one commit.

Test:

@can-anyscale can-anyscale force-pushed the can-rel01 branch 6 times, most recently from 3744747 to 4d595c4 Compare January 24, 2024 03:02
@can-anyscale can-anyscale requested a review from a team January 24, 2024 04:47
.buildkite/release/config.yml Show resolved Hide resolved
Comment on lines +28 to +30
tags: skip-on-premerge
key: anyscalemlbuild
instance_type: release
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is exposing anyscale image building on ray postmerge now, which does not feel quite right.

maybe we can just have a per commit build on release test pipeline? or maybe a release-perf pipeline?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postmerge probably should also be private; the fact that someone can create a PR and run it on postmerge (through a new build) and postmerge has right access also does not seem right

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someone can create a PR and run it on postmerge

only authorized members in the buildkite org can launch manual runs. but the results are public, so any one can see it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any strong opinion if I ask in #opensource to see if we can make it private; I'm leaning toward a direction of less number of pipelines if we can rather than more

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm.. you can ask, I don't think people would prefer to make postmerge private though. I think people prefer to maintain an open posture and keep things transparent.

at least there are cases where people need to goto the pipeline and find the wheel that is built for the commit.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let me ask around ;)

Signed-off-by: can <can@anyscale.com>
@can-anyscale
Copy link
Collaborator Author

pending switching postmerge to private ;)

Add the microbenchmark.aws in postmerge

Signed-off-by: can <can@anyscale.com>
@can-anyscale can-anyscale merged commit 746b55c into master Jan 30, 2024
3 of 6 checks passed
@can-anyscale can-anyscale deleted the can-rel01 branch January 30, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants