Revert "Revert "Revert "Revert "[core] Support encrypted redis connection." (#28991)""" #29109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishbone
force-pushed
the
revert-29078-revert-29061-revert-revert-28991
branch
from
814f3b6 to
7119c99
Compare
rkooo567
approved these changes
Oct 7, 2022
maxpumperla
pushed a commit
that referenced
this pull request
Oct 7, 2022
…tion." (#28991)""" (#29109) Reverts #29078 There are two issues: tsan fail and mac build fail. For TSAN, if we build redis + openssl with tsan the redis will segfault. So we exclude the redis target from the tsan build. For mac failure, the root cause is that in the CI somehow the toolchain picked in rules_foreign_cc is wrong. Failed to find any useful solution within a day. So just use the old build for mac and pick in the runtime. Since redis is only used for testing, win/mac/linux both support rediss.
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…tion." (ray-project#28991)""" (ray-project#29109) Reverts ray-project#29078 There are two issues: tsan fail and mac build fail. For TSAN, if we build redis + openssl with tsan the redis will segfault. So we exclude the redis target from the tsan build. For mac failure, the root cause is that in the CI somehow the toolchain picked in rules_foreign_cc is wrong. Failed to find any useful solution within a day. So just use the old build for mac and pick in the runtime. Since redis is only used for testing, win/mac/linux both support rediss. Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #29078
There are two issues: tsan fail and mac build fail.
For TSAN, if we build redis + openssl with tsan the redis will segfault. So we exclude the redis target from the tsan build.
For mac failure, the root cause is that in the CI somehow the toolchain picked in rules_foreign_cc is wrong. Failed to find any useful solution within a day. So just use the old build for mac and pick in the runtime.
Since redis is only used for testing, win/mac/linux both support rediss.