Revert "Revert "[core] Support encrypted redis connection." (#28991)" #29061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishbone
force-pushed
the
revert-revert-28991
branch
from
84d4023 to
91aee06
Compare
|
Try to run mac test as well. |
|
@krfricke I clicked the run mac tests and the mac still won't run. Actually in the first PR (the one being reverted), I also trigger the mac tests and it's pending: Is there something wrong in the testing infra? |
rkooo567
approved these changes
Oct 5, 2022
|
Synced offline: @krfricke is going to debug why the mac tests hang forever. I'm going to merge it first. We'll revert it again if it breaks anything. |
rkooo567
added a commit
that referenced
this pull request
Oct 5, 2022
rkooo567
added a commit
that referenced
this pull request
Oct 5, 2022
fishbone
added a commit
that referenced
this pull request
Oct 7, 2022
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…ect#28991)" (ray-project#29061) Fix the mac building issues. Verified in local mac. Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…ay-project#28991)" (ray-project#29061)" (ray-project#29078) This reverts commit 9277f9d. Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Fix the mac building issues. Verified in local mac.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.