Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lint] Update clang-tidy rules #19025

Merged
merged 1 commit into from
Oct 1, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions .clang-tidy
Original file line number Diff line number Diff line change
@@ -1,27 +1,43 @@
# Disable the following checks due to frequent false positives, noisiness,
# inconsistent style with existing codebase and other reasons:
# Disable the following checks with reasons in parenthesis:
#
# -bugprone-macro-parentheses (inconsistent style)
# -google-readability-todo (potentially too restrictive)
# -misc-non-private-member-variables-in-classes (potentially too restrictive)
# -misc-unused-parameters (can be cleaned up in batch and enabled)
# -modernize-avoid-c-arrays (too restrictive)
# -modernize-concat-nested-namespaces (inconsistent style)
# -modernize-pass-by-value (too restrictive)
# -modernize-return-braced-init-list (inconsistent style)
# -modernize-use-emplace (more subtle behavior)
# -modernize-use-trailing-return-type (inconsistent style)
# -modernize-use-trailing-return-type (inconsistent style)
# -readability-convert-member-functions-to-static (potentially too restrictive)
# Other rules not mentioned here or below (not yet evaluated)
#
# TODO: enable google-* and readability-* families of checks.
Checks: >
abseil-*,
bugprone-*,
-bugprone-macro-parentheses,
google-*,
-google-readability-todo,
misc-*,
-misc-non-private-member-variables-in-classes,
-misc-unused-parameters,
modernize-*,
-modernize-avoid-c-arrays,
-modernize-concat-nested-namespaces,
-modernize-pass-by-value,
-modernize-return-braced-init-list,
-modernize-use-emplace,
-modernize-use-trailing-return-type,
performance-*,
readability-avoid-const-params-in-decls,
readability-braces-around-statements,
readability-const-return-type,
readability-container-size-empty,
readability-delete-null-pointer,
readability-else-after-return,

CheckOptions:
# Reduce noisiness of the bugprone-narrowing-conversions check.
Expand Down