[Lint] Update clang-tidy rules #19025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwtian
force-pushed
the
clang-tidy-rules
branch
from
53d7168 to
72c6f8f
Compare
scv119
approved these changes
Sep 30, 2021
clarkzinzow
approved these changes
Sep 30, 2021
mwtian
added
the
tests-ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
It has been reported that rules
modernize-concat-nested-namespacesandbugprone-macro-parenthesesare a bit inconsistent with existing style. Disabling them for now. Also add a few more rules that seem useful.Related issue number
Checks
scripts/format.shto lint the changes in this PR.